Fix translated rich text attribute hydration and storage in admin#2445
Merged
alecritson merged 4 commits intolunarphp:1.xfrom Apr 13, 2026
Merged
Conversation
added 2 commits
April 11, 2026 14:59
The names would be listed twice for both the attribute groups and the attribute names within a group. This fixes that. Includes testing for this fix too.
This was referenced Apr 12, 2026
alecritson
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
Translated rich text product attributes were not being normalized correctly when Lunar built the Filament form state.
That caused two related problems:
This mainly affected multiline translated fields such as descriptions and similar rich text attributes in the product editor.
What Changed
-Converted any per-locale TipTap document arrays to HTML during dehydration, which matches what Lunar core expects to persist.
Result
Translated rich text attributes now:
Scope
This patch only addresses the main hydration/persistence issue in AttributeData.
The separate TranslatedTextSynth changes are intentionally excluded from this PR.
Code Generation Source
I highly supervised Codex 5.4 on Extra reasoning settings. I have also personally tested the results within the Lunar admin panel, and the patch is working as expected. During testing, Codex pointed out other issues that I will submit changes requests for, namely the TranslatedText and TranslatedTextSynth for testing.